-
-
Notifications
You must be signed in to change notification settings - Fork 34.5k
gh-145552: smtplib: quoteaddr() returns malformed address for input '<'
#145553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stefanzetzsche
wants to merge
10
commits into
python:main
Choose a base branch
from
stefanzetzsche:fix/smtplib_quoteaddr_malformed
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+19
−2
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
fc8b6c8
gh-XXXXX: Fix smtplib.quoteaddr() returning malformed address for '<'
stefanzetzsche 660ee12
test(smtplib): Add tests for quoteaddr angle-bracket handling
stefanzetzsche a95680f
📜🤖 Added by blurb_it.
blurb-it[bot] 2e8d602
Merge remote-tracking branch 'origin/main' into fix/smtplib_quoteaddr…
stefanzetzsche 6f22581
Merge branch 'fix/smtplib_quoteaddr_malformed' of https://github.com/…
stefanzetzsche 2378a95
Simplify fix: remove startswith check, restore unconditional wrapping
stefanzetzsche d135510
Merge remote-tracking branch 'origin/main' into fix/smtplib_quoteaddr…
stefanzetzsche 68a384f
Update comment to reflect unconditional wrapping behavior
stefanzetzsche 55fa703
Preserve already-bracketed input (e.g. null sender <>), wrap everythi…
stefanzetzsche 29d8166
Remove unnecessary comments from test cases
stefanzetzsche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Library/2026-03-05-15-20-18.gh-issue-145552.80p_Cr.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Fix ``smtplib.quoteaddr()`` to ensure the returned address always has a closing ``>`` when the input starts with ``<`` but ``email.utils.parseaddr()`` fails to parse it. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in responding.
I'd prefer to do
addrstring.strip() == '<>', which theoretically matches the old behavior. (I say theoretically because the code the old version of this code was calling has moved on as well and I don't feel like going down that rabbit hole.) In any case, it should be correct: only<>is a special case per RFC 5321; we otherwise don't want to do more to fix user errors than to ensure that the provided originator address is sorrounded by the angle quotes.