Added boot benchmark support to update_flash.c#759
Open
dgarske wants to merge 1 commit intowolfSSL:masterfrom
Open
Added boot benchmark support to update_flash.c#759dgarske wants to merge 1 commit intowolfSSL:masterfrom
dgarske wants to merge 1 commit intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds BOOT_BENCHMARK instrumentation to the flash-based boot path so integrity and signature verification steps can be timed, and provides a VA416x0 HAL microsecond timer implementation plus an example config toggle.
Changes:
- Add BENCHMARK_* hooks around integrity and signature verification in
wolfBoot_start()forupdate_flash. - Implement
hal_get_timer_us()for VA416x0 using SysTick +HAL_time_mswhenBOOT_BENCHMARK(or disk update) is enabled. - Document the optional
BOOT_BENCHMARKconfig toggle in the VA416x0 example config.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/update_flash.c | Adds benchmark timing/logging around integrity and signature checks during flash boot. |
| hal/va416x0.c | Adds a microsecond timer function used by benchmarking (and disk-update builds). |
| config/examples/vorago_va416x0.config | Documents how to enable boot benchmarking for the VA416x0 example target. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1489
to
+1495
| BENCHMARK_END("done"); | ||
| } | ||
| if (bootRet >= 0) { | ||
| wolfBoot_printf("Verifying signature..."); | ||
| BENCHMARK_START(); | ||
| bootRet = wolfBoot_verify_authenticity(&boot); | ||
| BENCHMARK_END("done"); |
Comment on lines
+596
to
+599
| uint32_t val = SysTick->VAL; | ||
| uint32_t elapsed_ticks = load - val; | ||
|
|
||
| return (HAL_time_ms * 1000ULL) + |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.