Skip to content

fix: remove secret keys from logging #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cuericlee merged 2 commits into from
Aug 18, 2025
Merged

fix: remove secret keys from logging #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
604568c
remove secret keys from logging
yaozheng-fang Aug 18, 2025
f510151
remove secret output from kb logging
yaozheng-fang Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions veadk/knowledgebase/knowledgebase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,7 @@ def __init__(
top_k: int = 10,
db_config=None,
):
logger.info(
f"Initializing knowledgebase: backend={backend} top_k={top_k} db_config={db_config}"
)
logger.info(f"Initializing knowledgebase: backend={backend} top_k={top_k}")

self.backend = backend
self.top_k = top_k
Expand All @@ -43,7 +41,7 @@ def __init__(
self.adapter = get_knowledgebase_database_adapter(self.db_client)

logger.info(
f"Initialized knowledgebase: db_client={self.db_client} adapter={self.adapter}"
f"Initialized knowledgebase: db_client={self.db_client.__class__.__name__} adapter={self.adapter}"
)

def add(
Expand Down
2 changes: 1 addition & 1 deletion veadk/memory/long_term_memory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def __init__(
self.adapter = get_long_term_memory_database_adapter(self.db_client)

logger.info(
f"Initialized long term memory: db_client={self.db_client} adapter={self.adapter}"
f"Initialized long term memory: db_client={self.db_client.__class__.__name__} adapter={self.adapter}"
)

def _filter_and_convert_events(self, events: list[Event]) -> list[str]:
Expand Down
10 changes: 3 additions & 7 deletions veadk/memory/short_term_memory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,18 +60,14 @@ def __init__(
self.session_service = InMemorySessionService()
elif self.backend == "database":
if self.db_url == "" or self.db_url is None:
logger.warning(
f"The `db_url` {self.db_url} is an empty or None string."
)
logger.warning("The `db_url` is an empty or None string.")
self._use_default_database()
else:
try:
self.session_service = DatabaseSessionService(db_url=self.db_url)
logger.info("Connected to database.")
logger.info("Connected to database with db_url.")
except Exception as e:
logger.error(
f"Failed to connect to database {self.db_url}, error: {e}."
)
logger.error(f"Failed to connect to database, error: {e}.")
self._use_default_database()
else:
raise ValueError(f"Unknown short term memory backend: {self.backend}")
Expand Down