Skip to content

Commit 58bc727

Browse files
committed
chore: remove no_extract arg from workbook download
1 parent d84adec commit 58bc727

1 file changed

Lines changed: 1 addition & 12 deletions

File tree

tableauserverclient/server/endpoint/workbooks_endpoint.py

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -182,9 +182,8 @@ def download(
182182
workbook_id: str,
183183
filepath: Optional[PathOrFileW] = None,
184184
include_extract: bool = True,
185-
no_extract: Optional[bool] = None,
186185
) -> str:
187-
return self.download_revision(workbook_id, None, filepath, include_extract, no_extract)
186+
return self.download_revision(workbook_id, None, filepath, include_extract, )
188187

189188
# Get all views of workbook
190189
@api(version="2.0")
@@ -445,7 +444,6 @@ def download_revision(
445444
revision_number: Optional[str],
446445
filepath: Optional[PathOrFileW] = None,
447446
include_extract: bool = True,
448-
no_extract: Optional[bool] = None,
449447
) -> PathOrFileW:
450448
if not workbook_id:
451449
error = "Workbook ID undefined."
@@ -455,15 +453,6 @@ def download_revision(
455453
else:
456454
url = "{0}/{1}/revisions/{2}/content".format(self.baseurl, workbook_id, revision_number)
457455

458-
if no_extract is False or no_extract is True:
459-
import warnings
460-
461-
warnings.warn(
462-
"no_extract is deprecated, use include_extract instead.",
463-
DeprecationWarning,
464-
)
465-
include_extract = not no_extract
466-
467456
if not include_extract:
468457
url += "?includeExtract=False"
469458

0 commit comments

Comments
 (0)