chore: remove deprecated site arg in auth

Author: jorwoods

tableauserverclient/models/tableau_auth.py

@@ -28,10 +28,7 @@ def deprecate_site_attribute():
 
 # The traditional auth type: username/password
 class TableauAuth(Credentials):
-    def __init__(self, username, password, site=None, site_id=None, user_id_to_impersonate=None):
-        if site is not None:
-            deprecate_site_attribute()
-            site_id = site
+    def __init__(self, username, password, site_id=None, user_id_to_impersonate=None):
         super().__init__(site_id, user_id_to_impersonate)
         if password is None:
             raise TabError("Must provide a password when using traditional authentication")
@@ -49,16 +46,6 @@ def __repr__(self):
             uid = ""
         return f"<Credentials username={self.username} password=redacted (site={self.site_id}{uid})>"
 
-    @property
-    def site(self):
-        deprecate_site_attribute()
-        return self.site_id
-
-    @site.setter
-    def site(self, value):
-        deprecate_site_attribute()
-        self.site_id = value
-
 
 # A Tableau-generated Personal Access Token
 class PersonalAccessTokenAuth(Credentials):

test/test_tableauauth_model.py

@@ -1,5 +1,4 @@
 import unittest
-import warnings
 
 import tableauserverclient as TSC
 
@@ -12,10 +11,3 @@ def test_username_password_required(self):
         with self.assertRaises(TypeError):
             TSC.TableauAuth()
 
-    def test_site_arg_raises_warning(self):
-        with warnings.catch_warnings(record=True) as w:
-            warnings.simplefilter("always")
-
-            tableau_auth = TSC.TableauAuth("user", "password", site="Default")
-
-            self.assertTrue(any(item.category == DeprecationWarning for item in w))