fix: correct undefined variable typo in AWK scripts#9804
Merged
Planeshifter merged 1 commit intostdlib-js:developfrom Jan 18, 2026
Merged
fix: correct undefined variable typo in AWK scripts#9804Planeshifter merged 1 commit intostdlib-js:developfrom
Planeshifter merged 1 commit intostdlib-js:developfrom
Conversation
Contributor
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
nakul-krishnakumar
pushed a commit
to nakul-krishnakumar/stdlib
that referenced
this pull request
Jan 25, 2026
PR-URL: stdlib-js#9804 Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
tools/awk/variance.awkandtools/awk/stdev.awkwhere an undefined variablemuwas used instead of the correctly initialized variablemeanRelated Issues
This pull request has the following related issues:
Questions
No.
Other
Both scripts implement Welford's method for computing variance/standard deviation. The variable
meanis properly initialized and updated during iteration, but line 44 incorrectly referencedmu, which is never defined. AWK treats undefined variables as 0, causing incorrect calculations.Checklist
AI Assistance
@stdlib-js/reviewers