Skip to content

feat: add math/base/special/round2f#9695

Open
aryan7071 wants to merge 6 commits intostdlib-js:developfrom
aryan7071:add-round2f
Open

feat: add math/base/special/round2f#9695
aryan7071 wants to merge 6 commits intostdlib-js:developfrom
aryan7071:add-round2f

Conversation

@aryan7071
Copy link
Copy Markdown
Contributor

@aryan7071 aryan7071 commented Jan 11, 2026 •
edited
Loading

Description

What is the purpose of this pull request?

This pull request:

  • Adds the complete implementation for math/base/special/round2f

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@aryan7071
feat: add math/base/special/round2f
89970dd 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@aryan7071
feat: add math/base/special/round2f
9dfd371 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Jan 11, 2026
@aryan7071
feat: add math/base/special/round2f
86eb9d0 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@aryan7071
fix: correct round2f implementation
81644b0 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Jan 11, 2026 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
math/base/special/round2f $\color{green}180/180$
$\color{green}+0.00%$ 		$\color{green}14/14$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}180/180$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@aryan7071
Copy link
Copy Markdown
Contributor Author

aryan7071 commented Jan 11, 2026

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 11, 2026
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 11, 2026
@Planeshifter Planeshifter changed the title feat: add math/base/special/round2f feat: add math/base/special/round2f Jan 11, 2026
Planeshifter
Planeshifter requested changes Jan 11, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

Comment thread lib/node_modules/@stdlib/math/base/special/round2f/src/main.c Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/round2f/test/test.native.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/round2f/test/test.native.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/round2f/test/test.native.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/round2f/test/test.native.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/round2f/test/test.native.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/round2f/test/test.native.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/round2f/test/test.native.js Outdated
@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jan 11, 2026
@aryan7071
fix: align round2f C style and native tests with stdlib conventions
bc5e16d 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Planeshifter Planeshifter self-requested a review January 13, 2026 05:10
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 13, 2026
@Planeshifter Planeshifter removed the Needs Changes Pull request which needs changes before being merged. label Jan 13, 2026
@Planeshifter
Copy link
Copy Markdown
Member

Planeshifter commented Jan 13, 2026

/stdlib lint-autofix

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 13, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Jan 13, 2026

/stdlib lint-autofix

@Planeshifter, the slash command failed to complete. Please check the workflow logs for details.

View workflow run

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 13, 2026
@aryan7071 aryan7071 mentioned this pull request Jan 13, 2026
Closed
@aryan7071 aryan7071 mentioned this pull request Jan 27, 2026
Closed
nirmaljb
nirmaljb reviewed Mar 15, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/math/base/special/round2f/lib/main.js

if ( x < 0.0 ) {
x = -x;
sign = -1.0;
Copy link
Copy Markdown
Contributor

@nirmaljb nirmaljb Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good practice to put these floats as separate variables.
Such as: var ONE = f32( 1.0 );

@aryan7071 aryan7071 mentioned this pull request Mar 19, 2026
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Awaiting requested review from Planeshifter

1 more reviewer

@nirmaljb nirmaljb nirmaljb left review comments

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aryan7071 @stdlib-bot @Planeshifter @nirmaljb