feat!: migrate utils/deep-set to object/deep-set#9691
feat!: migrate utils/deep-set to object/deep-set#9691kgryte merged 4 commits intostdlib-js:developfrom
utils/deep-set to object/deep-set#9691Conversation
This commit removes the `deepSet` symbol from the `@stdlib/utils` namespace due to a package migration. BREAKING CHANGE: remove `deepSet` To migrate, users should access the same symbol via the `@stdlib/object` namespace. Ref: stdlib-js#8755
This commit removes `@stdlib/utils/deep-set` in favor of `@stdlib/object/deep-set`. BREAKING CHANGE: remove `utils/deep-set` To migrate, users should update their require/import paths to use `@stdlib/object/deep-set` which provides the same API and implementation. Ref: stdlib-js#8755
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
Given that lint errors are not due to changes in this PR I'll go ahead and open this for review |
|
Found a couple of issues during review: 1. Missing update to
|
|
@Planeshifter Thanks for flagging this Will close this PR and create 2 new ones addressing both the changes |
|
@Planeshifter Your comments are not relevant to this PR. Please read https://github.com/stdlib-js/stdlib/blob/develop/docs/contributing/moving_packages.md.
I suggest not using AI code reviews on the migration PRs that Neeraj is working on. I am reopening this PR. |
|
@Neerajpathak07 Once merged, you can submit a PR fixing the typo in |
|
@kgryte That works as well! |
|
@kgryte can we land this in!!! |
Progresses #8755
Description
This pull request:
utils/deep-settoobject/deep-setRelated Issues
This pull request has the following related issues:
utilspackages toobject(tracking issue) #8755Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers