chore: fix JavaScript lint errors (issue #9687)#9690
Merged
Planeshifter merged 1 commit intostdlib-js:developfrom Jan 11, 2026
Merged
chore: fix JavaScript lint errors (issue #9687)#9690Planeshifter merged 1 commit intostdlib-js:developfrom
Planeshifter merged 1 commit intostdlib-js:developfrom
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Planeshifter
approved these changes
Jan 11, 2026
Contributor
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
kgryte
reviewed
Jan 11, 2026
| // Cache the most recent results... | ||
| if ( arguments.length > 1 ) { | ||
| args = new Array( arguments.length-1 ); | ||
| args = new Array( arguments.length-1 ); // eslint-disable-line stdlib/no-new-array |
Member
There was a problem hiding this comment.
This is not the correct change. This should have been converted to [] and then use #.push in the loop.
kgryte
reviewed
Jan 11, 2026
| var COL_MAJOR_REV_PIVOTS_IPIV_STRIDE = require( './fixtures/column_major_reverse_pivots_ipiv_stride.json' ); // eslint-disable-line id-length | ||
| var COL_MAJOR_REV_PIVOTS_IPIV_OFFSET = require( './fixtures/column_major_reverse_pivots_ipiv_offset.json' ); // eslint-disable-line id-length | ||
| var COL_MAJOR_K1 = require( './fixtures/column_major_k1.json' ); | ||
|
|
Member
There was a problem hiding this comment.
This also isn't the desired change. Here we actually want the empty line in order to visually group related fixtures. The lint rule should have been disabled here.
nakul-krishnakumar
pushed a commit
to nakul-krishnakumar/stdlib
that referenced
this pull request
Jan 25, 2026
PR-URL: stdlib-js#9690 Closes: stdlib-js#9687 Ref: stdlib-js#5377 Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves #9687
Description
This pull request:
Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers