Skip to content

test: add special value tests for log1pmx #9491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashish-066 wants to merge 5 commits into
base: develop
Choose a base branch
from
+17 −0
Open

test: add special value tests for log1pmx #9491

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7f3e63a
test: add special value tests for log1pmx
ashish-066 Jan 2, 2026
d889fdd
test(log1pmx): add spacing between test blocks
ashish-066 Jan 2, 2026
71c2ab6
test: add infinite value tests for xlog1py
ashish-066 Jan 3, 2026
6d77580
Revert "test: add infinite value tests for xlog1py"
ashish-066 Jan 3, 2026
d8a16e4
test(log1pmx): align special value tests with stdlib conventions
ashish-066 Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions lib/node_modules/@stdlib/math/base/special/log1pmx/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,20 @@ tape( 'the function returns a Taylor series expansion otherwise', function test(
}
t.end();
});
tape( 'the function handles special values', function test( t ) {
var v;

v = log1pmx( NaN );
t.strictEqual( isnan( v ), true, 'returns NaN for NaN' );

v = log1pmx( Infinity );
t.strictEqual( isnan( v ), true, 'returns NaN for +Infinity' );

v = log1pmx( -Infinity );
t.strictEqual( isnan( v ), true, 'returns NaN for -Infinity' );

v = log1pmx( -0.0 );
t.strictEqual( Object.is( v, -0.0 ), true, 'preserves negative zero' );
Copy link
Copy Markdown
Member

@kgryte kgryte Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this make sense?

Copy link
Copy Markdown
Author

@ashish-066 ashish-066 Jan 2, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the current implementation already preserves -0. The purpose of this test is to explicitly specify

Copy link
Copy Markdown
Member

@kgryte kgryte Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I am asking you to think more critically about whether that makes sense.

In general, we should not be adding tests for the sake of adding tests. Adding tests such as those you have added here document the desired public contract with downstream consumers. We should ensure that the contract makes sense mathematically. It is possible that the implementation is incorrect.

Copy link
Copy Markdown
Author

@ashish-066 ashish-066 Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the misunderstanding. You are right there is no mathematical necessity to specify signed zero behavior for log1pmx.I have removed the -0 test case


t.end();
});