Skip to content

style: use single quotes for require calls#11516

Merged
kgryte merged 2 commits intodevelopfrom
philipp/fix-commit-review-2026-04-17
Apr 18, 2026
Merged

style: use single quotes for require calls#11516
kgryte merged 2 commits intodevelopfrom
philipp/fix-commit-review-2026-04-17

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter commented Apr 17, 2026

Description

What is the purpose of this pull request?

This pull request:

  • replaces backticks with single quotes in the @example require() paths to match the d.ts convention used across the rest of the repository.

Follow-up review window: commits merged to develop between 2026-04-17 07:23 +0530 and 2026-04-18 01:09 +0500 (24h).

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance.

This PR was written by Claude Code as a follow-up review of the 24h develop commit window; each change is a one-line style fix and was independently re-verified against the diff before committing.


@stdlib-js/reviewers

@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Apr 17, 2026

Coverage Report

Package Statements Branches Functions Lines
ndarray/base/to-unflattened $\color{green}112/112$
$\color{green}+100.00%$
$\color{green}3/3$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}112/112$
$\color{green}+100.00%$
ndarray/base/unflatten $\color{red}160/162$
$\color{green}+98.77%$
$\color{red}6/7$
$\color{green}+85.71%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{red}160/162$
$\color{green}+98.77%$
ndarray/remove-singleton-dimensions $\color{green}104/104$
$\color{green}+100.00%$
$\color{green}5/5$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}104/104$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@stdlib-js stdlib-js deleted a comment from stdlib-bot Apr 17, 2026
@Planeshifter Planeshifter changed the title Follow-up fixes for develop commits merged 2026-04-17 → 2026-04-18 style: use single quotes for require call in ndarray/base/to-unflattened Apr 17, 2026
@Planeshifter Planeshifter marked this pull request as ready for review April 17, 2026 21:06
@Planeshifter Planeshifter requested a review from a team April 17, 2026 21:06
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Apr 17, 2026
@Planeshifter Planeshifter marked this pull request as draft April 17, 2026 21:26
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Apr 17, 2026
@Planeshifter Planeshifter force-pushed the philipp/fix-commit-review-2026-04-17 branch from 8eb4529 to d03f7d8 Compare April 17, 2026 21:47
@Planeshifter Planeshifter reopened this Apr 17, 2026
@Planeshifter Planeshifter marked this pull request as ready for review April 17, 2026 21:59
@Planeshifter Planeshifter changed the title style: use single quotes for require call in ndarray/base/to-unflattened style: use single quotes for require calls Apr 17, 2026
@Planeshifter Planeshifter requested a review from kgryte April 17, 2026 22:00
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Apr 17, 2026
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Apr 18, 2026
@kgryte kgryte merged commit 3af178c into develop Apr 18, 2026
83 checks passed
@kgryte kgryte deleted the philipp/fix-commit-review-2026-04-17 branch April 18, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants