Skip to content

fix: dgemm not handling conjugate-transpose#11107

Closed
dhruvan2006 wants to merge 2 commits intostdlib-js:developfrom
dhruvan2006:feat/is-transposed
Closed

fix: dgemm not handling conjugate-transpose#11107
dhruvan2006 wants to merge 2 commits intostdlib-js:developfrom
dhruvan2006:feat/is-transposed

Conversation

@dhruvan2006
Copy link
Copy Markdown
Contributor

Description

What is the purpose of this pull request?

dgemm does not handle conjugate-transpose explicitly since the if conditions only checked if transA === 'transpose' which is dangerous.
Therefore, I decided to implement the TODO:s and refactored isTransposed function into a new package.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Mar 23, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/base/assert/is-transposed $\color{green}99/99$
$\color{green}+100.00%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}99/99$
$\color{green}+100.00%$
blas/base/dgemm $\color{green}813/813$
$\color{green}+100.00%$
$\color{green}117/117$
$\color{green}+100.00%$
$\color{green}7/7$
$\color{green}+100.00%$
$\color{green}813/813$
$\color{green}+100.00%$
blas/base/dgemv $\color{red}723/724$
$\color{green}+99.86%$
$\color{red}115/116$
$\color{green}+99.14%$
$\color{green}5/5$
$\color{green}+100.00%$
$\color{red}723/724$
$\color{green}+99.86%$
blas/base/ggemm $\color{red}1283/1292$
$\color{green}+99.30%$
$\color{red}170/173$
$\color{green}+98.27%$
$\color{green}12/12$
$\color{green}+100.00%$
$\color{red}1283/1292$
$\color{green}+99.30%$
blas/base/ggemv $\color{red}635/637$
$\color{green}+99.69%$
$\color{red}98/100$
$\color{green}+98.00%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{red}635/637$
$\color{green}+99.69%$
blas/base/sgemm $\color{green}814/814$
$\color{green}+100.00%$
$\color{green}117/117$
$\color{green}+100.00%$
$\color{green}7/7$
$\color{green}+100.00%$
$\color{green}814/814$
$\color{green}+100.00%$
blas/base/sgemv $\color{red}725/726$
$\color{green}+99.86%$
$\color{red}115/116$
$\color{green}+99.14%$
$\color{green}5/5$
$\color{green}+100.00%$
$\color{red}725/726$
$\color{green}+99.86%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Copy Markdown
Member

kgryte commented Mar 23, 2026

Mind splitting this into two separate PRs? One PR which only implements the assertion utility and then another PR which makes the changes in the downstream packages? This ensures we have a clean commit history on merge.

@dhruvan2006
Copy link
Copy Markdown
Contributor Author

Mind splitting this into two separate PRs? One PR which only implements the assertion utility and then another PR which makes the changes in the downstream packages? This ensures we have a clean commit history on merge.

Opened #11110 and #11111

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants