Skip to content

bench: refactor to use string interpolation in blas/ext/base/ssumpw#10890

Merged
kgryte merged 2 commits intostdlib-js:developfrom
parthodas23:rfc/blas-ext-base-ssumpw
Mar 13, 2026
Merged

bench: refactor to use string interpolation in blas/ext/base/ssumpw#10890
kgryte merged 2 commits intostdlib-js:developfrom
parthodas23:rfc/blas-ext-base-ssumpw

Conversation

@parthodas23
Copy link
Copy Markdown
Contributor

@parthodas23 parthodas23 commented Mar 12, 2026

Progresses #8647 .

Description

What is the purpose of this pull request?

This pull request:

  • bench: refactor to use string interpolation in blas/ext/base/ssumpw

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Mar 12, 2026
@parthodas23 parthodas23 changed the title bench: refactor to use string interpolation in blas/ext/base/ssumpw bench: refactor to use string interpolation in blas/ext/base/ssumpw Mar 12, 2026
@parthodas23 parthodas23 force-pushed the rfc/blas-ext-base-ssumpw branch from d0abb33 to f00bedb Compare March 12, 2026 07:18
@stdlib-bot
Copy link
Copy Markdown
Contributor

⚠️ Tracking Issue Closure Warning ⚠️

I noticed your PR description contains closing keywords ("Resolves", "Closes", or "Fixes") referencing a "Tracking Issue".

Why this matters:
Tracking issues should typically remain open until all related sub-issues are completed. GitHub automatically closes issues with such closing keywords when the PR is merged. For more information, see GitHub's documentation on using keywords in issues and pull requests.

Required action:
Use "Progresses" instead to reference the tracking issue without automatically closing it.

Thank you for your contribution to the project!

@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Benchmarks Pull requests adding or improving benchmarks for measuring performance. bot: Merge Pull request needing the latest project code be merged in. review: 5 and removed Needs Review A pull request which needs code review. labels Mar 12, 2026
@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: Merge Pull request needing the latest project code be merged in. labels Mar 12, 2026
@kgryte kgryte removed the bot: In Progress Pull request is currently awaiting automation. label Mar 13, 2026
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Mar 13, 2026

As the CI failure is not due to changes introduced in this PR, I'll go ahead and merge.

@kgryte kgryte merged commit 8510d5a into stdlib-js:develop Mar 13, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmarks Pull requests adding or improving benchmarks for measuring performance. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. review: 5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants