Skip to content

chore: address commit comments for commit 2255c38 (issue #10849)#10857

Closed
MANDEep22332 wants to merge 6 commits intostdlib-js:developfrom
MANDEep22332:chore-2255c38-fix
Closed

chore: address commit comments for commit 2255c38 (issue #10849)#10857
MANDEep22332 wants to merge 6 commits intostdlib-js:developfrom
MANDEep22332:chore-2255c38-fix

Conversation

@MANDEep22332
Copy link
Copy Markdown
Contributor

@MANDEep22332 MANDEep22332 commented Mar 10, 2026

Resolves #10849

Description

What is the purpose of this pull request?

This pull request:

  • {{TODO: change the strided array to arrays in the readme.md
  • implement the isnan in the benchmark.js}}

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 10, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@kgryte
Copy link
Copy Markdown
Member

kgryte commented Mar 10, 2026

Ref: #10855

@kgryte kgryte added autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. and removed Needs Review A pull request which needs code review. labels Mar 10, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit.

Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions.

@stdlib-bot stdlib-bot closed this Mar 10, 2026
@github-actions github-actions Bot mentioned this pull request Mar 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Issue Reference Review

An automated check found a potentially unrelated issue/PR reference in this PR:

Reference Assessment Reasoning
#10848 suspicious PR is specifically about addressing commit 2255c38 comments (issue #10849, affecting dnanstdevch and snanmskminabs), but #10848 is about a different commit (949d17d) for a different package (nanrangeabs). No clear connection.

Why this matters: GitHub automatically closes issues referenced with closing keywords (Resolves, Closes, Fixes) when the PR is merged. Incorrect references can accidentally close unrelated issues.

What to do:

  • If the reference is correct, no action needed. This check may produce false positives.
  • If the reference is incorrect, please update your PR description.

This assessment was generated by an AI model and is informational only.

Generated by Check PR Issue References ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address commit comments (commit 2255c38)

3 participants