Skip to content

bench: refactor to use string interpolation in blas/ext/cusum#10822

Merged
Planeshifter merged 1 commit intostdlib-js:developfrom
rautelaKamal:refactor/bench-string-interpolation-blas-ext-cusum
Mar 8, 2026
Merged

bench: refactor to use string interpolation in blas/ext/cusum#10822
Planeshifter merged 1 commit intostdlib-js:developfrom
rautelaKamal:refactor/bench-string-interpolation-blas-ext-cusum

Conversation

@rautelaKamal
Copy link
Copy Markdown
Contributor

@rautelaKamal rautelaKamal commented Mar 8, 2026

Ref: #8647.

Description

What is the purpose of this pull request?

This pull request:

  • Refactors the JavaScript benchmarks in @stdlib/blas/ext/cusum to use string interpolation (@stdlib/string/format) for generating benchmark names instead of string concatenation, as outlined in the tracking issue #8647.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Mar 8, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Mar 8, 2026

Coverage Report

Package Statements Branches Functions Lines
blas/ext/cusum $\color{green}485/485$
$\color{green}+100.00%$
$\color{green}48/48$
$\color{green}+100.00%$
$\color{green}2/2$
$\color{green}+100.00%$
$\color{green}485/485$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@rautelaKamal rautelaKamal force-pushed the refactor/bench-string-interpolation-blas-ext-cusum branch 2 times, most recently from 7e896e4 to c0e07d4 Compare March 8, 2026 18:33
@rautelaKamal rautelaKamal force-pushed the refactor/bench-string-interpolation-blas-ext-cusum branch from c0e07d4 to 78abc34 Compare March 8, 2026 18:39
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 8, 2026
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 8, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

PR Commit Message

bench: refactor to use string interpolation in blas/ext/cusum

PR-URL: https://github.com/stdlib-js/stdlib/pull/10822
Ref: https://github.com/stdlib-js/stdlib/issues/8647

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

⚠️ Action Required: This PR references tracking issues. Please update the PR description to replace any "Closes", "Fixes", or "Resolves" keywords with "Ref" when referencing these issues.

@Planeshifter Planeshifter merged commit 5f8e258 into stdlib-js:develop Mar 8, 2026
30 checks passed
@stdlib-bot stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Mar 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants