bench: use string interpolation in math/base/special/floor#10736
Merged
Planeshifter merged 1 commit intostdlib-js:developfrom Mar 7, 2026
Merged
Conversation
Replace string concatenation with `@stdlib/string/format` when specifying benchmark names in JavaScript benchmarks for the `@stdlib/math/base/special/floor` package. Ref: stdlib-js#8647 Co-authored-by: Egger <egger@horny-toad.com>
Planeshifter
approved these changes
Mar 6, 2026
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Contributor
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
Witty-31-06
pushed a commit
to Witty-31-06/stdlib
that referenced
this pull request
Mar 7, 2026
PR-URL: stdlib-js#10736 Ref: stdlib-js#8647 Co-authored-by: Egger <egger@horny-toad.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Ref: #8647
Description
This pull request migrates the JavaScript benchmarks in
@stdlib/math/base/special/floorfrom string concatenation to@stdlib/string/formatwhen specifying benchmark names.Changes:
benchmark.js:pkg+'::built-in'→format( '%s::built-in', pkg )benchmark.native.js:pkg+'::native'→format( '%s::native', pkg )Both files now import
@stdlib/string/format.Related Issues
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
Used Claude to identify the package and apply the string interpolation pattern per the RFC instructions.
@stdlib-js/reviewers
Co-authored-by: Egger egger@horny-toad.com