chore: fix JavaScript lint errors (issue #10708)#10725
chore: fix JavaScript lint errors (issue #10708)#10725travisbreaks wants to merge 1 commit intostdlib-js:developfrom
Conversation
Replace `new Array( 1e4 )` with `buffer = []; buffer.length = 1e4;` to satisfy the stdlib/no-new-array lint rule in ndarray/fancy/test/test.instance.tostring.js. Co-authored-by: Egger <egger@horny-toad.com>
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
Closing as this overlaps with existing work (Potential Duplicate label). Happy to reopen if maintainers would like me to continue. |
Description
Fixes the
stdlib/no-new-arraylint error reported in issue #10708 by replacing thenew Array()constructor with an array literal.Changes
lib/node_modules/@stdlib/ndarray/fancy/test/test.instance.tostring.js(line 178): Replacenew Array( 1e4 )withbuffer = []; buffer.length = 1e4;to create a sparse array without using theArrayconstructor.Related Issues
Resolves #10708
Co-authored-by: Egger egger@horny-toad.com
Checklist