Skip to content

chore: fix JavaScript lint errors (issue #10184)#10724

Merged
kgryte merged 3 commits intostdlib-js:developfrom
travisbreaks:fix/issue-10184
Apr 7, 2026
Merged

chore: fix JavaScript lint errors (issue #10184)#10724
kgryte merged 3 commits intostdlib-js:developfrom
travisbreaks:fix/issue-10184

Conversation

@travisbreaks
Copy link
Copy Markdown
Contributor

@travisbreaks travisbreaks commented Mar 6, 2026

Description

Fixes the stdlib/no-new-array lint errors reported in issue #10184 by replacing new Array() constructor calls with array literals.

Changes

  • lib/node_modules/@stdlib/math/strided/special/ahavercos-by/test/test.main.js: Replace new Array( 5 ) sparse array construction with x = []; x.length = 5; pattern (2 occurrences). Remove associated eslint-disable-next-line directives.
  • lib/node_modules/@stdlib/assert/is-empty-collection/test/test.js: Replace new Array( 10 ) with an explicit array literal [ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 ].

Related Issues

Resolves #10184


Co-authored-by: Egger egger@horny-toad.com

Checklist

- Replace `new Array( 5 )` with `x = []; x.length = 5;` for sparse arrays in ahavercos-by/test/test.main.js
- Replace `new Array( 10 )` with array literal in is-empty-collection/test/test.js
- Remove unnecessary eslint-disable-next-line directives

Co-authored-by: Egger <egger@horny-toad.com>
@stdlib-bot
Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Mar 6, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. and removed First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Mar 6, 2026
@travisbreaks
Copy link
Copy Markdown
Contributor Author

Friendly ping — just checking if this is on the review radar. Happy to adjust if anything needs changes. Thanks!

@kgryte
Copy link
Copy Markdown
Member

kgryte commented Mar 22, 2026

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Mar 22, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Mar 22, 2026

Coverage Report

Package Statements Branches Functions Lines
assert/is-empty-collection $\color{green}102/102$
$\color{green}+0.00%$
$\color{green}5/5$
$\color{green}+0.00%$
$\color{green}1/1$
$\color{green}+0.00%$
$\color{green}102/102$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

ahavercosBy( x.length, x, 1, y, 1, accessor );
t.deepEqual( y, expected, 'deep equal' );

// eslint-disable-next-line stdlib/no-new-array
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are undesired.

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Mar 22, 2026
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Needs Changes Pull request which needs changes before being merged. review: 3 and removed Needs Review A pull request which needs code review. labels Mar 22, 2026
@github-actions github-actions Bot mentioned this pull request Mar 22, 2026
Restore original `new Array(5)` sparse array construction and
eslint-disable directives per maintainer review feedback. Only the
is-empty-collection test fix remains.

Co-Authored-By: Claude Opus 4.6 (1M context) <tadao@travisfixes.com>
@travisbreaks
Copy link
Copy Markdown
Contributor Author

@kgryte The revert is done in the latest force-push. Removed the eslint-disable directive changes and the new Array() replacement in ahavercos-by. Only the is-empty-collection fixes remain. Ready for re-review when you have a chance.

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Apr 7, 2026
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte merged commit 2c3cce1 into stdlib-js:develop Apr 7, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. review: 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants