chore: fix JavaScript lint errors (issue #10184)#10724
chore: fix JavaScript lint errors (issue #10184)#10724kgryte merged 3 commits intostdlib-js:developfrom
Conversation
- Replace `new Array( 5 )` with `x = []; x.length = 5;` for sparse arrays in ahavercos-by/test/test.main.js - Replace `new Array( 10 )` with array literal in is-empty-collection/test/test.js - Remove unnecessary eslint-disable-next-line directives Co-authored-by: Egger <egger@horny-toad.com>
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
Friendly ping — just checking if this is on the review radar. Happy to adjust if anything needs changes. Thanks! |
|
/stdlib merge |
Coverage Report
The above coverage report was generated for the changes in this PR. |
| ahavercosBy( x.length, x, 1, y, 1, accessor ); | ||
| t.deepEqual( y, expected, 'deep equal' ); | ||
|
|
||
| // eslint-disable-next-line stdlib/no-new-array |
Restore original `new Array(5)` sparse array construction and eslint-disable directives per maintainer review feedback. Only the is-empty-collection test fix remains. Co-Authored-By: Claude Opus 4.6 (1M context) <tadao@travisfixes.com>
89820ed to
98d3083
Compare
|
@kgryte The revert is done in the latest force-push. Removed the eslint-disable directive changes and the |
Description
Fixes the
stdlib/no-new-arraylint errors reported in issue #10184 by replacingnew Array()constructor calls with array literals.Changes
lib/node_modules/@stdlib/math/strided/special/ahavercos-by/test/test.main.js: Replacenew Array( 5 )sparse array construction withx = []; x.length = 5;pattern (2 occurrences). Remove associatedeslint-disable-next-linedirectives.lib/node_modules/@stdlib/assert/is-empty-collection/test/test.js: Replacenew Array( 10 )with an explicit array literal[ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 ].Related Issues
Resolves #10184
Co-authored-by: Egger egger@horny-toad.com
Checklist