Skip to content

bench: refactor the generation of sort arrays to include randomness#10705

Open
pranavthakur0-0 wants to merge 1 commit intostdlib-js:developfrom
pranavthakur0-0:fix/sorted-benchmark-randomness
Open

bench: refactor the generation of sort arrays to include randomness#10705
pranavthakur0-0 wants to merge 1 commit intostdlib-js:developfrom
pranavthakur0-0:fix/sorted-benchmark-randomness

Conversation

@pranavthakur0-0
Copy link
Copy Markdown

Resolves #10415 .

Description

What is the purpose of this pull request?

This pull request:

  • improves sorted array generation in C benchmarks for sorted-input packages by adding a random factor to the generated values using the already existing rand_double()/rand_float() functions and srand( time( NULL ) ) seeding, which were previously unused. Affected packages: stats/strided/dminsorted, stats/strided/dmaxsorted, stats/strided/dmediansorted, stats/strided/sminsorted, stats/strided/smaxsorted, stats/strided/smediansorted, stats/strided/dmaxabssorted, and stats/strided/smaxabssorted.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Mar 4, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@kgryte kgryte changed the title fix: improve sorted arrays generation in C benchmarks for bench: refactor the generation of sort arrays to include randomness Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Improve sorted arrays generation in C benchmarks for sorted-input packages

2 participants