Skip to content

bench: refactor to use string interpolation in blas/ext/base/sdsnansum#10580

Closed
rautelaKamal wants to merge 3 commits intostdlib-js:developfrom
rautelaKamal:bench-sdsnansum
Closed

bench: refactor to use string interpolation in blas/ext/base/sdsnansum#10580
rautelaKamal wants to merge 3 commits intostdlib-js:developfrom
rautelaKamal:bench-sdsnansum

Conversation

@rautelaKamal
Copy link
Copy Markdown
Contributor

Ref #8647.

Description

What is the purpose of this pull request?

This pull request:

  • Refactors the JavaScript benchmarks in @stdlib/blas/ext/base/sdsnansum to use string interpolation via @stdlib/string/format instead of string concatenation for constructing benchmark names.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Feb 28, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Hello! 👋

We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm!

Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks.

Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀

For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers!

@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Feb 28, 2026

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/sdsnansum $\color{green}344/344$
$\color{green}+100.00%$
$\color{green}13/13$
$\color{green}+100.00%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{green}344/344$
$\color{green}+100.00%$
stats/base/dists/erlang/pdf $\color{green}198/198$
$\color{green}+100.00%$
$\color{green}9/9$
$\color{green}+100.00%$
$\color{green}2/2$
$\color{green}+100.00%$
$\color{green}198/198$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Benchmarks Pull requests adding or improving benchmarks for measuring performance. review: 5 and removed Needs Review A pull request which needs code review. labels Feb 28, 2026
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Feb 28, 2026

@rautelaKamal You have unrelated changes in this PR. This suggests that you did not properly follow our branching guidance in the dev guide.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. review: 3 and removed review: 5 labels Feb 28, 2026
@kgryte kgryte changed the title bench: refactor to use string interpolation in blas/ext/base/sdsnansum bench: refactor to use string interpolation in blas/ext/base/sdsnansum Feb 28, 2026
@rautelaKamal rautelaKamal reopened this Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmarks Pull requests adding or improving benchmarks for measuring performance. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. Needs Changes Pull request which needs changes before being merged. review: 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants