Skip to content

bench: refactor to use string interpolation in buffer/from-string#10500

Merged
Planeshifter merged 1 commit intostdlib-js:developfrom
rautelaKamal:feature/buffer/from-string-bench-string-interpolation
Feb 27, 2026
Merged

bench: refactor to use string interpolation in buffer/from-string#10500
Planeshifter merged 1 commit intostdlib-js:developfrom
rautelaKamal:feature/buffer/from-string-bench-string-interpolation

Conversation

@rautelaKamal
Copy link
Copy Markdown
Contributor

@rautelaKamal rautelaKamal commented Feb 25, 2026

Ref #8647.

Description

What is the purpose of this pull request?

This pull request:

  • Refactors benchmark names in @stdlib/buffer/from-string to use string interpolation via @stdlib/string/format instead of string concatenation.

Related Issues

Does this pull request have any related issues?

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Feb 25, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Feb 25, 2026

Coverage Report

Package Statements Branches Functions Lines
buffer/from-string $\color{green}206/206$
$\color{green}+100.00%$
$\color{green}20/20$
$\color{green}+100.00%$
$\color{green}2/2$
$\color{green}+100.00%$
$\color{green}206/206$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter changed the title bench: refactor to use string interpolation in buffer/from-string bench: refactor to use string interpolation in buffer/from-string Feb 26, 2026
@rautelaKamal rautelaKamal force-pushed the feature/buffer/from-string-bench-string-interpolation branch from 85026bf to 3d281df Compare February 26, 2026 01:45
@rautelaKamal
Copy link
Copy Markdown
Contributor Author

@Planeshifter The run_affected_tests failure appears to be unrelated to the benchmark changes in this PR. The failing step runs tests for all downstream packages that depend on @stdlib/buffer/from-string, and the failure is occurring in one of those dependent packages — not in buffer/from-string itself.

Evidence:

  • lint_changed_files ✅ passes
  • run_affected_benchmarks ✅ passes
  • run_tests_coverage_pr ✅ passes with 100% coverage
  • Only benchmark/benchmark.js was modified — no changes to source or test files

The benchmark refactoring follows the exact pattern from the reference commit (086231d). Happy to address any other feedback!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Feb 27, 2026
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 27, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

PR Commit Message

bench: refactor to use string interpolation in `buffer/from-string`

PR-URL: https://github.com/stdlib-js/stdlib/pull/10500
Ref: https://github.com/stdlib-js/stdlib/issues/8647

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

⚠️ Action Required: This PR references tracking issues. Please update the PR description to replace any "Closes", "Fixes", or "Resolves" keywords with "Ref" when referencing these issues.

@Planeshifter Planeshifter merged commit 89d9070 into stdlib-js:develop Feb 27, 2026
29 of 30 checks passed
@stdlib-bot stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Feb 27, 2026
Witty-31-06 pushed a commit to Witty-31-06/stdlib that referenced this pull request Mar 7, 2026
PR-URL: stdlib-js#10500
Ref: stdlib-js#8647

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants