Skip to content

bench: refactor to use string interpolation in stats/**/nanmax-by packages #10495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 6 commits into from
Apr 11, 2026
Merged

bench: refactor to use string interpolation in stats/**/nanmax-by packages #10495

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c3ece04
bench: refactor to use string interpolation in stats/nanmax-by
rautelaKamal Apr 4, 2026
4a17c37
Merge branch 'develop' into feature/stats/nanmax-by-bench-string-inte…
rautelaKamal Apr 4, 2026
a7d62a3
docs: restore JSDoc comment
kgryte Apr 11, 2026
06a862f
Apply suggestions from code review
kgryte Apr 11, 2026
3ecef14
Apply suggestions from code review
kgryte Apr 11, 2026
63b1888
Apply suggestions from code review
kgryte Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions lib/node_modules/@stdlib/stats/base/ndarray/nanmax-by/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ var bernoulli = require( '@stdlib/random/base/bernoulli' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pow = require( '@stdlib/math/base/special/pow' );
var ndarray = require( '@stdlib/ndarray/base/ctor' );
var format = require( '@stdlib/string/format' );
var pkg = require( './../package.json' ).name;
var nanmaxBy = require( './../lib' );

Expand Down Expand Up @@ -109,11 +110,6 @@ function createBenchmark( len ) {

// MAIN //

/**
* Main execution sequence.
*
* @private
*/
function main() {
Comment thread
kgryte marked this conversation as resolved.
var len;
var min;
Expand All @@ -127,7 +123,7 @@ function main() {
for ( i = min; i <= max; i++ ) {
len = pow( 10, i );
f = createBenchmark( len );
bench( pkg+':len='+len, f );
bench( format( '%s:dtype=%s,len=%d', pkg, options.dtype, len ), f );
Comment thread
kgryte marked this conversation as resolved.
Outdated
}
}

Expand Down
6 changes: 3 additions & 3 deletions lib/node_modules/@stdlib/stats/nanmax-by/benchmark/benchmark.assign.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var format = require( '@stdlib/string/format' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pow = require( '@stdlib/math/base/special/pow' );
var uniform = require( '@stdlib/random/array/uniform' );
var zeros = require( '@stdlib/array/zeros' );
var ndarray = require( '@stdlib/ndarray/base/ctor' );
var zeros = require( '@stdlib/array/zeros' );
var pow = require( '@stdlib/math/base/special/pow' );
var format = require( '@stdlib/string/format' );
var pkg = require( './../package.json' ).name;
var nanmaxBy = require( './../lib' );

Expand Down
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/stats/nanmax-by/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var format = require( '@stdlib/string/format' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pow = require( '@stdlib/math/base/special/pow' );
var uniform = require( '@stdlib/random/array/uniform' );
var ndarray = require( '@stdlib/ndarray/base/ctor' );
var pow = require( '@stdlib/math/base/special/pow' );
var format = require( '@stdlib/string/format' );
var pkg = require( './../package.json' ).name;
var nanmaxBy = require( './../lib' );

Expand Down
8 changes: 2 additions & 6 deletions lib/node_modules/@stdlib/stats/strided/nanmax-by/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ var filledarrayBy = require( '@stdlib/array/filled-by' );
var bernoulli = require( '@stdlib/random/base/bernoulli' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pow = require( '@stdlib/math/base/special/pow' );
var format = require( '@stdlib/string/format' );
var pkg = require( './../package.json' ).name;
var nanmaxBy = require( './../lib/main.js' );

Expand Down Expand Up @@ -96,11 +97,6 @@ function createBenchmark( len ) {

// MAIN //

/**
* Main execution sequence.
*
* @private
*/
function main() {
Comment thread
kgryte marked this conversation as resolved.
var len;
var min;
Expand All @@ -114,7 +110,7 @@ function main() {
for ( i = min; i <= max; i++ ) {
len = pow( 10, i );
f = createBenchmark( len );
bench( pkg+':len='+len, f );
bench( format( '%s:len=%d', pkg, len ), f );
}
}

Expand Down
8 changes: 2 additions & 6 deletions lib/node_modules/@stdlib/stats/strided/nanmax-by/benchmark/benchmark.ndarray.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ var filledarrayBy = require( '@stdlib/array/filled-by' );
var bernoulli = require( '@stdlib/random/base/bernoulli' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pow = require( '@stdlib/math/base/special/pow' );
var format = require( '@stdlib/string/format' );
var pkg = require( './../package.json' ).name;
var nanmaxBy = require( './../lib/ndarray.js' );

Expand Down Expand Up @@ -96,11 +97,6 @@ function createBenchmark( len ) {

// MAIN //

/**
* Main execution sequence.
*
* @private
*/
function main() {
Comment thread
kgryte marked this conversation as resolved.
var len;
var min;
Expand All @@ -114,7 +110,7 @@ function main() {
for ( i = min; i <= max; i++ ) {
len = pow( 10, i );
f = createBenchmark( len );
bench( pkg+':ndarray:len='+len, f );
bench( format( '%s:ndarray:len=%d', pkg, len ), f );
}
}

Expand Down