Skip to content

chore: fix JavaScript lint errors (issue #10000) #10307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Planeshifter merged 5 commits into from
Feb 17, 2026
Merged

chore: fix JavaScript lint errors (issue #10000) #10307

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cfa53ee
chore: fix JavaScript lint errors (issue #10000)
Sid-V5 Feb 15, 2026
5c14181
fix: usage of `require( 'process' )` instead of global `process`
Sid-V5 Feb 16, 2026
36b195b
chore: remove extra backslashes
Planeshifter Feb 16, 2026
c26aab0
chore: minor clean-up
Planeshifter Feb 16, 2026
4a09326
Merge branch 'develop' into fix/lint-proc-undefined
Sid-V5 Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/node_modules/@stdlib/_tools/makie/plugins/makie-install-node-addons/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ var spawn = require( 'child_process' ).spawn;
* @param {Error} error - error object
*/
function onError( error ) {
proc.exitCode = 1;
process.exitCode = 1;
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The right fix here is to add the missing import rather than switching to the process global.

If you look at every other sibling makie plugin (e.g., makie-test, makie-benchmark, makie-examples -- all 21 of them), they all have this at line 23:

var proc = require( 'process' );
var spawn = require( 'child_process' ).spawn;

This file is the only one missing that require( 'process' ) import. That's the actual root cause of the lint error.

The fix should be to add var proc = require( 'process' ); before the spawn require (line 23) and then revert all four callback changes back to using proc. This keeps consistency with every other plugin in this directory and follows the stdlib convention of using require('process') rather than relying on the process global.

console.error( 'Error: %s', error.message ); // eslint-disable-line no-console
}

Expand All @@ -45,7 +45,7 @@ function onError( error ) {
*/
function onFinish( code ) {
if ( code !== 0 ) {
proc.exitCode = code;
process.exitCode = code;
return console.error( 'Child process exited with code `'+code + '`.' ); // eslint-disable-line no-console
}
}
Expand All @@ -57,7 +57,7 @@ function onFinish( code ) {
* @param {Buffer} data - standard output
*/
function stdout( data ) {
proc.stdout.write( data );
process.stdout.write( data );
}

/**
Expand All @@ -67,7 +67,7 @@ function stdout( data ) {
* @param {Buffer} data - standard error
*/
function stderr( data ) {
proc.stderr.write( data );
process.stderr.write( data );
}


Expand Down
Loading