Skip to content

feat: add Wald distribution mode package#10205

Merged
Planeshifter merged 14 commits intostdlib-js:developfrom
manit2004:feat/wald-distribution-mode-209
Apr 30, 2026
Merged

feat: add Wald distribution mode package#10205
Planeshifter merged 14 commits intostdlib-js:developfrom
manit2004:feat/wald-distribution-mode-209

Conversation

@manit2004
Copy link
Copy Markdown
Contributor

@manit2004 manit2004 commented Feb 10, 2026

Progresses #209 .

Description

What is the purpose of this pull request?

  • Complete package for Wald mode has been implemented.

Related Issues

Does this pull request have any related issues?

  • None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Feb 10, 2026
@manit2004 manit2004 changed the title Feat/wald distribution mode 209 feat: add Wald distribution mode package Feb 10, 2026
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 10, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Feb 10, 2026

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/wald/mode $\color{green}179/179$
$\color{green}+0.00%$
$\color{green}10/10$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}179/179$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

Copy link
Copy Markdown
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left initial round of review. Thanks for the PR!

Comment thread lib/node_modules/@stdlib/stats/base/dists/wald/mode/benchmark/c/Makefile Outdated
Comment thread lib/node_modules/@stdlib/stats/base/dists/wald/mode/lib/main.js Outdated
Comment thread lib/node_modules/@stdlib/stats/base/dists/wald/mode/lib/main.js Outdated
Comment thread lib/node_modules/@stdlib/stats/base/dists/wald/mode/test/test.js Outdated
Comment thread lib/node_modules/@stdlib/stats/base/dists/wald/mode/test/test.js Outdated
Comment on lines +225 to +231
}
```

</section>

<!-- /.examples -->

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The C example in the README doesn't match examples/c/example.c. The actual example uses i < 25 (not i < 10), lambda range up to 20.0 (not 10.0), and printf( "µ: %lf, ..." with %lf (not %.4f). Let's sync these so they match.

Comment thread lib/node_modules/@stdlib/stats/base/dists/wald/mode/manifest.json
@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Feb 14, 2026
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 15, 2026
@manit2004
Copy link
Copy Markdown
Contributor Author

@Planeshifter suggested changes has been implemented. Please take a look.

Copy link
Copy Markdown
Member

@Neerajpathak07 Neerajpathak07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manit2004 Thanks for working on this. Couple more tweaks!!

Comment thread lib/node_modules/@stdlib/stats/base/dists/wald/mode/README.md
Comment thread lib/node_modules/@stdlib/stats/base/dists/wald/mode/lib/index.js
@Neerajpathak07 Neerajpathak07 added difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. review: 3 labels Feb 28, 2026
Comment thread lib/node_modules/@stdlib/stats/base/dists/wald/mode/lib/main.js
Comment thread lib/node_modules/@stdlib/stats/base/dists/wald/mode/docs/repl.txt Outdated
@manit2004
Copy link
Copy Markdown
Contributor Author

@Planeshifter @Neerajpathak07 Suggested changes have been implemented, please take a look.

@manit2004
Copy link
Copy Markdown
Contributor Author

@Neerajpathak07 @Planeshifter @kgryte can you please review this PR, requested changes have been applied.

@github-actions github-actions Bot mentioned this pull request Apr 23, 2026
@Planeshifter Planeshifter requested a review from a team April 30, 2026 03:49
@Planeshifter Planeshifter force-pushed the feat/wald-distribution-mode-209 branch from 91ad58e to 308e19a Compare April 30, 2026 05:00
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after some clean-up. Thanks, @manit2004!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Apr 30, 2026
@stdlib-bot stdlib-bot removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Apr 30, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Apr 30, 2026

PR Commit Message

feat: add `stats/base/dists/wald/mode`

PR-URL: https://github.com/stdlib-js/stdlib/pull/10205
Ref: https://github.com/stdlib-js/stdlib/issues/209

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Neeraj Pathak <neerajrpathak710@gmail.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter dismissed Neerajpathak07’s stale review April 30, 2026 06:14

Everything has been addressed.

@Planeshifter Planeshifter merged commit 4479454 into stdlib-js:develop Apr 30, 2026
32 of 33 checks passed
@stdlib-bot stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. review: 3 Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants