Use EPS instead of 0.1 in C benchmark files#10194
Use EPS instead of 0.1 in C benchmark files#10194HWKDS wants to merge 1 commit intostdlib-js:developfrom
Conversation
Replace hardcoded 0.1 constant with STDLIB_CONSTANT_FLOAT64_EPS in statistical distribution benchmark files for non-zero positive lower bounds. Ref: stdlib-js#10174 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
|
/stdlib help |
|
@HWKDS, available slash commands include:
|
|
/stdlib lint-autofix |
@HWKDS, the slash command failed to complete. Please check the workflow logs for details. |
|
See comment in #10174 (comment). |
|
Sure, my bad> See comment in #10174 (comment). |
Replace hardcoded 0.1 constant with STDLIB_CONSTANT_FLOAT64_EPS in statistical distribution benchmark files for non-zero positive lower bounds.
Ref: #10174
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
Resolves #10174.
Description
This pull request:
0.1constant withSTDLIB_CONSTANT_FLOAT64_EPSin C benchmark files for statistical distributions#include "stdlib/constants/float64/eps.h"to affected benchmark filesRelated Issues
This pull request has the following related issues:
Questions
No.
Other
The changes follow a consistent pattern across all files:
random_uniform(0.1, max)withrandom_uniform(STDLIB_CONSTANT_FLOAT64_EPS, max)for distribution parameters that must be strictly positiveChecklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
I consulted GitHub Copilot to understand the issue requirements, contributing guidelines, and Git workflow. The code changes were implemented manually by me following the RFC specifications. Copilot assisted with documentation and PR formatting.
@stdlib-js/reviewers