feat: add stats/incr/nanrss by kanikasharma-18 · Pull Request #10082 · stdlib-js/stdlib

kanikasharma-18 · 2026-02-04T16:55:29Z

Resolves #5622

Description

What is the purpose of this pull request?

This pull request:-

Adds an incremental residual sum of squares (RSS) accumulator.
Ignores NaN input values during accumulation.
Returns the previously accumulated RSS when inputs contain NaN
Passes all existing test cases and maintains backward compatibility.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
Result of tests:-

Result for benchmark:-

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

kanikasharma-18 · 2026-02-23T08:18:57Z

@nakul-krishnakumar @kgryte @Planeshifter Kindly review my PR.

Planeshifter

Thanks for your PR!

Planeshifter · 2026-03-09T05:35:35Z

+
+## Notes
+
+-   Input values are **not** type checked. If provided `NaN` or a value which, when used in computations, results in `NaN`, the accumulated value is `NaN` for **all** future invocations. If non-numeric inputs are possible, you are advised to type check and handle accordingly **before** passing the value to the accumulator function.


This note was copied from incr/rss and directly contradicts the purpose of this package. The whole point of nanrss is to ignore NaN values. Should be:

Suggested change

- Input values are **not** type checked. If provided `NaN` or a value which, when used in computations, results in `NaN`, the accumulated value is `NaN` for **all** future invocations. If non-numeric inputs are possible, you are advised to type check and handle accordingly **before** passing the value to the accumulator function.

- Input values are **not** type checked. If non-numeric inputs are possible, you are advised to type check and handle accordingly **before** passing the value to the accumulator function.

Planeshifter · 2026-03-09T05:35:39Z

+		if ( arguments.length === 0 ) {
+			return nansum();
+		}
+		if ( x !== x || y !== y ) {


Use isnan from @stdlib/math/base/assert/is-nan. All other nan-wrapper packages do. Also, the standard pattern is to wrap the non-nan base accumulator directly (i.e., wrap incrrss, not incrnansum) — see nanmstdev which wraps incrmstdev.

Planeshifter · 2026-03-09T05:35:42Z

+* r = accumulator( NaN, 3.0 );
+* // 50.0
+* r = accumulator( 5.0, NaN );
+* // 50.0


Missing returns:

Suggested change

* r = accumulator( NaN, 3.0 );

* // 50.0

* r = accumulator( 5.0, NaN );

* // 50.0

* r = accumulator( NaN, 3.0 );

* // returns 50.0

* r = accumulator( 5.0, NaN );

* // returns 50.0

Planeshifter · 2026-03-09T05:35:45Z

+
+#### accumulator( \[x, y] )
+
+If provided input values x and y, the accumulator function updates the RSS. If NaN is provided, it is ignored, and the previous RSS is returned. If no arguments are provided, the accumulator function returns the current RSS.


Doesn't match the style in incr/rss. Parameters should be in backticks, use the full term with link references, and follow the standard phrasing. Compare with incr/rss README.

Planeshifter · 2026-03-09T05:35:46Z

@@ -0,0 +1,31 @@
+{{alias}}()


Missing leading blank line. All repl.txt files start with an empty line before {{alias}}.

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Feb 4, 2026

kanikasharma-18 added 4 commits February 17, 2026 17:16

kanikasharma-18 marked this pull request as ready for review February 23, 2026 08:17

stdlib-bot added the Needs Review A pull request which needs code review. label Feb 23, 2026

Planeshifter requested changes Mar 9, 2026

View reviewed changes

Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 9, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add stats/incr/nanrss#10082

feat: add stats/incr/nanrss#10082
kanikasharma-18 wants to merge 5 commits intostdlib-js:developfrom
kanikasharma-18:nanrss-added

kanikasharma-18 commented Feb 4, 2026

Uh oh!

kanikasharma-18 commented Feb 23, 2026

Uh oh!

Planeshifter left a comment

Uh oh!

Planeshifter Mar 9, 2026

Uh oh!

Planeshifter Mar 9, 2026

Uh oh!

Planeshifter Mar 9, 2026

Uh oh!

Planeshifter Mar 9, 2026

Uh oh!

Planeshifter Mar 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		## Notes

		- Input values are not type checked. If provided `NaN` or a value which, when used in computations, results in `NaN`, the accumulated value is `NaN` for all future invocations. If non-numeric inputs are possible, you are advised to type check and handle accordingly before passing the value to the accumulator function.


		#### accumulator( \[x, y] )

		If provided input values x and y, the accumulator function updates the RSS. If NaN is provided, it is ignored, and the previous RSS is returned. If no arguments are provided, the accumulator function returns the current RSS.

Uh oh!

Conversation

kanikasharma-18 commented Feb 4, 2026

Description

Other

Checklist

AI Assistance

Uh oh!

kanikasharma-18 commented Feb 23, 2026

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants