Remove go.mod replace directive that breaks 'go install ...@latest'#4401
Merged
kyleconroy merged 2 commits intomainfrom Apr 21, 2026
Merged
Remove go.mod replace directive that breaks 'go install ...@latest'#4401kyleconroy merged 2 commits intomainfrom
kyleconroy merged 2 commits intomainfrom
Conversation
The replace directive pointing to the sqlc-dev/mysql fork was only needed by TestExpandMySQL, but it broke the install path documented at https://docs.sqlc.dev/en/latest/overview/install.html. Fixes #4397. Rewrite MySQLColumnGetter in internal/x/expander/expander_test.go to read column names from sql.Rows (the test tables are empty, so no rows are transferred), then drop the replace directive from go.mod. Add TestGoModHasNoReplaceDirectives and a dedicated CI job so the same regression surfaces as a quick, obvious failure rather than silently shipping in a release.
TestGoModHasNoReplaceDirectives already runs as part of the existing test job, so no separate CI job is needed to catch regressions of #4397.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The replace directive pointing to the sqlc-dev/mysql fork was only
needed by TestExpandMySQL, but it broke the install path documented
at https://docs.sqlc.dev/en/latest/overview/install.html. Fixes #4397.
Rewrite MySQLColumnGetter in internal/x/expander/expander_test.go to
read column names from sql.Rows (the test tables are empty, so no rows
are transferred), then drop the replace directive from go.mod.
Add TestGoModHasNoReplaceDirectives and a dedicated CI job so the same
regression surfaces as a quick, obvious failure rather than silently
shipping in a release.