fix: bundle ws types in declarations#209
Merged
chenjiahan merged 1 commit intomainfrom Apr 25, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the rslib DTS bundling configuration so the generated dist/index.d.ts can include the ws type surface without requiring consumers of @rspack/dev-server to install ws or @types/ws.
Changes:
- Add
@types/wsto thedts.bundle.bundledPackageslist for the server build.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the generated public declaration file self-contained for the
wstypes exposed by@rspack/dev-server. It bundles@types/wsduring dts generation so consumers can typecheck the package without installingwsor@types/wsthemselves.Fixes #206