Let --allow-redefinition-new widen global in function with None init#21285
Open
Let --allow-redefinition-new widen global in function with None init#21285
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
ilevkivskyi
approved these changes
Apr 21, 2026
Member
ilevkivskyi
left a comment
There was a problem hiding this comment.
Yeah, this is a bit ugly, but not too bad to maintain backwards compatibility for an important edge case.
I have just one suggestion.
| """Can a variable type be widened via assignment in the current scope? | ||
|
|
||
| Globals can only be widened from within a function if the original type | ||
| is None (backward compat with partial type handling of `x = None`). |
Member
There was a problem hiding this comment.
Maybe give some example relevant test cases here? Like e.g. testNewRedefineGlobalVariableNoneInit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now this infers an optional type, for backward compat with
--allow-redefinition-old:There are a few non-trivial things. The implementation propagates the widened type to the global scope, since otherwise
xwould have typeNoneat top level after the function. We also only allow widening if the original type isNone, to make reasoning about this easier. Otherwise the type could be inferred from any number of functions. Also this is sufficient to maintain backward compatibility.I used coding agent assist with small incremental changes and careful manual reviews.
See #21276 for additional context.