GH-147985: Use lock-free lookup in PySet_Contains().#147986
Merged
kumaraditya303 merged 2 commits intopython:mainfrom Apr 3, 2026
Merged
GH-147985: Use lock-free lookup in PySet_Contains().#147986kumaraditya303 merged 2 commits intopython:mainfrom
kumaraditya303 merged 2 commits intopython:mainfrom
Conversation
nascheme
added
type-feature
nascheme
changed the title
nascheme
changed the title
kumaraditya303
approved these changes
Apr 2, 2026
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
vstinner
approved these changes
Apr 2, 2026
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM. The implementation uses set_lookkey_threadsafe() which is safe on Free Threading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
PySet_Contains()attempt a lock-free lookup, similar toset.__contains__(). This avoids acquiring the set object mutex in the normal case.