Skip to content

gh-138573: filter out failing math tests on Solaris#146402

Merged
vstinner merged 1 commit intopython:mainfrom
skirpichev:filter-math-tests-on-sunos/138573
Mar 25, 2026
Merged

gh-138573: filter out failing math tests on Solaris#146402
vstinner merged 1 commit intopython:mainfrom
skirpichev:filter-math-tests-on-sunos/138573

Conversation

@skirpichev
Copy link
Copy Markdown
Member

@skirpichev skirpichev commented Mar 25, 2026

@vstinner
Copy link
Copy Markdown
Member

I can see the test_math.testAtan2() and test_cmath.test_phase() failures on the Solaris buildbot: https://buildbot.python.org/#/builders/742/builds/9890

ERROR: testAtan2 (test.test_math.MathTests.testAtan2)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/share/buildbot-worker/python/3.x.kulikjak-solaris-sparcv9/build/Lib/test/test_math.py", line 306, in testAtan2
    self.ftest('atan2(0., -0.)', math.atan2(0., -0.), math.pi)
                                 ~~~~~~~~~~^^^^^^^^^
ValueError: math domain error

and

ERROR: test_phase (test.test_cmath.CMathTests.test_phase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/share/buildbot-worker/python/3.x.kulikjak-solaris-sparcv9/build/Lib/test/test_cmath.py", line 410, in test_phase
    self.assertAlmostEqual(phase(0), 0.)
                           ~~~~~^^^
ValueError: math domain error

@vstinner
Copy link
Copy Markdown
Member

There are the two same errors on the 3.14 Solaris buildbot: https://buildbot.python.org/#/builders/1804/builds/808. So we can backport this change to 3.14.

On the 3.13 Solaris buildbot, test_math and test_cmath pass, so there is no need to backport to 3.13.

@vstinner vstinner merged commit 8e1469c into python:main Mar 25, 2026
54 checks passed
@miss-islington-app
Copy link
Copy Markdown

Thanks @skirpichev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 25, 2026
…46402)

(cherry picked from commit 8e1469c)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Mar 25, 2026

GH-146438 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Mar 25, 2026
@skirpichev skirpichev deleted the filter-math-tests-on-sunos/138573 branch March 25, 2026 23:13
vstinner pushed a commit that referenced this pull request Mar 26, 2026
#146438)

gh-138573: Filter out failing math tests on Solaris (GH-146402)
(cherry picked from commit 8e1469c)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Apr 16, 2026
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants