Skip to content

gh-145801: Use gcc -fprofile-update=atomic for PGO builds #145802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 3 commits into from
Mar 12, 2026
Merged

gh-145801: Use gcc -fprofile-update=atomic for PGO builds #145802

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dfb0a1a
gh-145801: Use gcc -fprofile-update=atomic for PGO builds
vstinner Mar 11, 2026
0f0da85
Add AX_CHECK_COMPILE_FLAG() test in configure
vstinner Mar 12, 2026
6306877
Clarify GCC mention in the NEWS entry
vstinner Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Misc/NEWS.d/next/Build/2026-03-11-11-58-42.gh-issue-145801.iCXa3v.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
When Python build is optimized by PGO, use GCC ``-fprofile-update=atomic``
option to use atomic operations when updating profile information. This option
reduces the risk of gcov Data Files (.gcda) corruption which can cause random
GCC crashes. Patch by Victor Stinner.
2 changes: 1 addition & 1 deletion configure
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2084,7 +2084,7 @@ case "$ac_cv_cc_name" in
fi
;;
gcc)
PGO_PROF_GEN_FLAG="-fprofile-generate"
PGO_PROF_GEN_FLAG="-fprofile-generate -fprofile-update=atomic"
PGO_PROF_USE_FLAG="-fprofile-use -fprofile-correction"
LLVM_PROF_MERGER="true"
LLVM_PROF_FILE=""
Expand Down
Loading