-
-
Notifications
You must be signed in to change notification settings - Fork 34.5k
gh-144316: Fix missing exception in _remote_debugging with debug=False #144442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
0f2d244
gh-144316: Fix missing exception in _remote_debugging with debug=False
taegyunkim 66b060d
📜🤖 Added by blurb_it.
blurb-it[bot] 3c72749
Vertically algin continuation character (\) per PEP-7
taegyunkim c42b64c
Shorten news entry as suggested
taegyunkim f2ad0ef
Call PyErr_NoMemory() on when PyMem_RawMalloc() returns NULL; typo am…
taegyunkim c0a8037
Update macro to crash in debug mode when error is not set
taegyunkim 07cb6e9
Merge branch 'main' into gh-144316-get_stack_trace
taegyunkim 173cde8
Adjust vertical bars per PEP-7
taegyunkim 29774d7
Assert before calling _set_debug_exception_cause
taegyunkim 0691413
Merge branch 'main' into gh-144316-get_stack_trace
taegyunkim 9e622ab
Merge branch 'main' into gh-144316-get_stack_trace
taegyunkim 39b6abe
Make sure to call PyErr before calling set_exception_cause
taegyunkim a1b0590
Merge branch 'main' into gh-144316-get_stack_trace
taegyunkim 51f5997
Merge branch 'main' into gh-144316-get_stack_trace
taegyunkim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Library/2026-02-03-19-57-41.gh-issue-144316.wop870.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Fix missing exception handling in :mod:`_remote_debugging` when ``debug=False``. The ``set_exception_cause`` macro now always sets an exception to satisfy the C API contract, fixing intermittent assertion failures. Exception chaining with ``debug=True`` is preserved. Patch by Taegyun Kim. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.