test_xpickle: Mark cpu resource as required#144349
Closed
smontanaro wants to merge 0 commit intopython:mainfrom
Closed
test_xpickle: Mark cpu resource as required#144349smontanaro wants to merge 0 commit intopython:mainfrom
test_xpickle: Mark cpu resource as required#144349smontanaro wants to merge 0 commit intopython:mainfrom
Conversation
test_xpickle: warning message when cpu resource is missing
test_xpickle: warning message when cpu resource is missingtest_xpickle: Mark cpu resource as required
StanFromIreland
approved these changes
Jan 30, 2026
Member
|
@smontanaro, did you intend to close this, or was it a mistake? (The commits are still recoverable: a201c26 12c4b35 e967287) |
Contributor
Author
|
Side effect of trying to fix my repo. I thought the trivial changes had already been committed, so didn't worry about it. Didn't someone (Serhiy?) comment that the cpu resource is no longer required anyway? |
Member
|
Ah! I didn't see the conversation, but it makes sense to me. With the specific So, let's keep it closed. For posterity, the patch was: --- a/Lib/test/test_xpickle.py
+++ b/Lib/test/test_xpickle.py
@@ -18,8 +18,9 @@
has_c_implementation = False
support.requires('xpickle')
+support.requires('cpu')
is_windows = sys.platform.startswith('win')
|
Member
|
The "cpu" resource is no longer required because the test is now 30 times faster. See #75572. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.