-
-
Notifications
You must be signed in to change notification settings - Fork 34.5k
gh-144140: Optimize len for string constants in optimizer #144142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
798fcb0
gh-144140: Optimize len for string constants in optimizer
y1yang0 d5ab2a2
whitespace; regen
y1yang0 364f008
Merge branch 'main' into yyang/call_len_opt
y1yang0 adcc3b3
obsolete print
y1yang0 4f523dc
byte string
y1yang0 1255bea
Merge branch 'main' into yyang/call_len_opt
Fidget-Spinner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1417,12 +1417,25 @@ dummy_func(void) { | |
|
|
||
| op(_CALL_LEN, (callable, null, arg -- res, a, c)) { | ||
| res = sym_new_type(ctx, &PyLong_Type); | ||
| Py_ssize_t tuple_length = sym_tuple_length(arg); | ||
| if (tuple_length >= 0) { | ||
| PyObject *temp = PyLong_FromSsize_t(tuple_length); | ||
| PyObject *temp = NULL; | ||
|
|
||
| Py_ssize_t length = sym_tuple_length(arg); | ||
| if (length >= 0) { | ||
| temp = PyLong_FromSsize_t(length); | ||
| if (temp == NULL) { | ||
| goto error; | ||
| } | ||
| } | ||
| else if (sym_is_const(ctx, arg)) { | ||
| PyObject *const_val = sym_get_const(ctx, arg); | ||
| if (const_val != NULL && PyUnicode_CheckExact(const_val)) { | ||
| temp = PyLong_FromSsize_t(PyUnicode_GET_LENGTH(const_val)); | ||
| if (temp == NULL) { | ||
| goto error; | ||
| } | ||
| } | ||
| } | ||
|
Comment on lines
+1428
to
+1441
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we can optimize the logic here: |
||
| if (temp != NULL) { | ||
| if (_Py_IsImmortal(temp)) { | ||
| ADD_OP(_SHUFFLE_3_LOAD_CONST_INLINE_BORROW, | ||
| 0, (uintptr_t)temp); | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also deal with the
PyBytes_CheckExact+PyBytes_GET_SIZE?