-
-
Notifications
You must be signed in to change notification settings - Fork 34.5k
gh-144140: Optimize len for string constants in optimizer #144142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
798fcb0
d5ab2a2
364f008
adcc3b3
4f523dc
1255bea
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1417,12 +1417,25 @@ dummy_func(void) { | |
|
|
||
| op(_CALL_LEN, (callable, null, arg -- res, a, c)) { | ||
| res = sym_new_type(ctx, &PyLong_Type); | ||
| Py_ssize_t tuple_length = sym_tuple_length(arg); | ||
| if (tuple_length >= 0) { | ||
| PyObject *temp = PyLong_FromSsize_t(tuple_length); | ||
| PyObject *temp = NULL; | ||
|
|
||
| Py_ssize_t length = sym_tuple_length(arg); | ||
| if (length >= 0) { | ||
| temp = PyLong_FromSsize_t(length); | ||
| if (temp == NULL) { | ||
| goto error; | ||
| } | ||
| } | ||
| else if (sym_is_const(ctx, arg)) { | ||
| PyObject *const_val = sym_get_const(ctx, arg); | ||
| if (const_val != NULL && PyUnicode_CheckExact(const_val)) { | ||
| temp = PyLong_FromSsize_t(PyUnicode_GET_LENGTH(const_val)); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we also deal with the |
||
| if (temp == NULL) { | ||
| goto error; | ||
| } | ||
| } | ||
| } | ||
|
Comment on lines
+1428
to
+1441
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we can optimize the logic here: |
||
| if (temp != NULL) { | ||
| if (_Py_IsImmortal(temp)) { | ||
| ADD_OP(_SHUFFLE_3_LOAD_CONST_INLINE_BORROW, | ||
| 0, (uintptr_t)temp); | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.