Skip to content

gh-143866: Verify return value of pathlib write methods in tests #143870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sobolevn merged 6 commits into from
Jan 19, 2026
Merged

gh-143866: Verify return value of pathlib write methods in tests #143870

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
be71fed
gh-143866: Verify return value of pathlib write methods in tests
b9788213 Jan 15, 2026
2c25d40
Update existing instead of creating a new one.
b9788213 Jan 15, 2026
8e9c767
Merge branch 'main' into gh-143866-pathlib-test
b9788213 Jan 16, 2026
8b1e0db
.
b9788213 Jan 16, 2026
7a8dd6f
.
b9788213 Jan 16, 2026
25ad87a
Merge branch 'main' into gh-143866-pathlib-test
sobolevn Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Lib/test/test_pathlib/test_write.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,11 @@ def test_write_bytes(self):
self.assertRaises(TypeError, p.write_bytes, 'somestr')
self.assertEqual(self.ground.readbytes(p), b'abcdefg')

def test_write_bytes_return(self):
p = self.root / 'fileA'
data = b'some bytes'
self.assertEqual(len(data), p.write_bytes(data))
Comment thread
sobolevn marked this conversation as resolved.
Outdated
Copy link
Copy Markdown
Member

@sobolevn sobolevn Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do the same here and move the check to the line 68?

Copy link
Copy Markdown
Contributor Author

@b9788213 b9788213 Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes i will

Copy link
Copy Markdown
Member

@sobolevn sobolevn Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fix the CI.

Copy link
Copy Markdown
Contributor Author

@b9788213 b9788213 Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My push from another device isnt synced.


def test_write_text(self):
p = self.root / 'fileA'
p.write_text('äbcdefg', encoding='latin-1')
Expand Down Expand Up @@ -113,6 +118,11 @@ def test_write_text_with_newlines(self):
b'abcde' + os_linesep_byte +
b'fghlk' + os_linesep_byte + b'\rmnopq')

def test_write_text_return(self):
p = self.root / 'fileA'
data = 'some text'
self.assertEqual(len(data), p.write_text(data))

def test_mkdir(self):
p = self.root / 'newdirA'
self.assertFalse(self.ground.isdir(p))
Expand Down