gh-135852: Remove out of tree pywin32 dependency for NTEventLogHandler

[aisk]

Please note that the lpUserSid parameter in ReportEvent don't added because it needs passing a new struct from Python to it, and we don't need this parameter for the usage of implement NTEventLogHandler. If we want add it in the future, we can add it as kwargs.

Docuements for these functions:

• RegisterEventSource: https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-registereventsourcew
• DeregisterEventSource: https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-deregistereventsource
• ReportEventW: https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-reporteventw

For the NTEventLogHandler, there is a implementation detail:

The old implementation based on pywin32, if dllname is not specified, pywin32 will using a vendored dll in that package, as a log template for the NT event log system.

For the new implement in this PR, if the dllname is not specified, I decided not to register the dll. As a result, the log still can be send to the NT Event Log System, we can see it in the Event Viewer.

But the event will show some thing like this (I just use a picture from the Internet because I'm using a localized Windows which the text is Chinese but they are the same thing):

And I think it's OK because we can check the Detail tab to see the original message, for develop purpose this is enough. For users with production usage, they can provide their own dlls as the message template.

• Issue: Remove external dependency for logging.handlers.NTEventLogHandler #135852

[sharktide]

Please fix the test fails :)

[aisk]

Sorry, I forgot to check the CI result after the push.

[serhiy-storchaka]

Thank you for your PR @aisk. It look interesting.

Could you please show how can this be used in NTEventLogHandler? Maybe not in this PR, but in a separate PR created on top of this?

[aisk]

Thank you for your PR @aisk. It look interesting.

Could you please show how can this be used in NTEventLogHandler? Maybe not in this PR, but in a separate PR created on top of this?

Thanks for the view! I'll create another PR based on this to try to implement the whole feature in the original issue.

[aisk]

@serhiy-storchaka Hi, I found that using this in NTEventLogHandler to replace pywin32 is very simple, so I push it directly on this branch, and also added some information on the top of this issue.

[serhiy-storchaka]

Very well. I have some nitpicks and questions, but mostly LGTM.

NTEventLogHandler only uses a single-string list and don't use a raw_data. Removing these features would simplify the code. But it is fine to keep them for future.

[aisk]

Hi, thank you for the review! I changed to just to support a single string as event log message to reduce the complexity, and now the codes are ready for review.

[serhiy-storchaka]

LGTM. 👍

[serhiy-storchaka]

Thank you for your contribution, @aisk. 🎄

[bedevere-bot]

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Arch Linux Asan Debug 3.x (no tier) has failed when building commit 3c4429f.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/585/builds/7088) and take a look at the build logs.
4. Check if the failure is related to this commit (3c4429f) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/585/builds/7088

Failed tests:

• test_math
• test_statistics
• test_profiling

Failed subtests:

• test_process_pool_executor_pickle - test.test_profiling.test_sampling_profiler.test_advanced.TestProcessPoolExecutorSupport.test_process_pool_executor_pickle

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64.asan_debug/build/Lib/test/test_profiling/test_sampling_profiler/test_advanced.py", line 237, in test_process_pool_executor_pickle
    self.assertIn("Results: [2, 4, 6]", stdout)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'Results: [2, 4, 6]' not found in ''