Skip to content

gh-144162: Allow for subclasses of a dataclass to define required fields when a parent has defined optional fields#133168

Open
LukeGrochocki wants to merge 1 commit intopython:mainfrom
LukeGrochocki:issue
Open

gh-144162: Allow for subclasses of a dataclass to define required fields when a parent has defined optional fields#133168
LukeGrochocki wants to merge 1 commit intopython:mainfrom
LukeGrochocki:issue

Conversation

@LukeGrochocki
Copy link
Copy Markdown

Fix for gh-144162

gh-133162: Allow for subclasses of a dataclass to define required fields when a parent has defined optional fields

@python-cla-bot
Copy link
Copy Markdown

python-cla-bot Bot commented Apr 29, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Apr 29, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Copy link
Copy Markdown
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I'd suggest looking at the devguide for the pull request tutorial.

A number of things I'd like you to change here:

  • Please move the test to somewhere in the existing dataclass tests.
  • This needs a blurb entry per the bot, but also needs a whatsnew entry for 3.14.
  • The title should be in a gh-NNNN: quick summary format.

The test is failing, FYI!

StanFromIreland

This comment was marked as duplicate.

@ericvsmith
Copy link
Copy Markdown
Member

Also, please give this a better title. I didn’t notice it in my inbox. Thanks!

@AA-Turner AA-Turner changed the title Fix for gh-144162 gh-144162: Allow for subclasses of a dataclass to define required fields when a parent has defined optional fields May 4, 2025
@AA-Turner
Copy link
Copy Markdown
Member

Still needs a better title, I just copied the one from the issue.

A

@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core review stale Stale PR or inactive for long period of time. topic-dataclasses

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants