-
Notifications
You must be signed in to change notification settings - Fork 235
docs: improve eventing image and wording #3303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,7 +13,7 @@ See the [integration test](https://github.com/operator-framework/java-operator-s | |
|
|
||
| ```java | ||
| public class DeploymentReconciler | ||
| implements Reconciler<Deployment>, TestExecutionInfoProvider { | ||
| implements Reconciler<Deployment> { | ||
|
Comment on lines
15
to
+16
|
||
|
|
||
| @Override | ||
| public UpdateControl<Deployment> reconcile( | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page no longer references
/images/event-sources.png(it’s been replaced by a Mermaid diagram). The updateddocs/static/images/event-sources.pngfile therefore appears to be unused now; consider removing it to avoid carrying a stale asset, or reintroduce a reference if you still want an image fallback for non-Mermaid renderers.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a valid point. If we're replacing the file by a mermaid diagram, we should remove the file as it doesn't appear to be used elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is removed, in the PR. Maybe it was a separate commit, so it did not recognize that.