fix: reject symlinked LocalFile sources#2972
Open
matthewflint wants to merge 4 commits intoopenai:mainfrom
Open
fix: reject symlinked LocalFile sources#2972matthewflint wants to merge 4 commits intoopenai:mainfrom
matthewflint wants to merge 4 commits intoopenai:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a00da33af
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
seratch
changed the title
Route LocalFile reads through the same pinned path handling used by LocalDir so symlinked source paths are rejected consistently. Add focused regression coverage for symlinked ancestor and leaf paths.
Signed-off-by: matthewflint <277024436+matthewflint@users.noreply.github.com>
matthewflint
force-pushed
the
fix/sandbox-localfile-symlink-rejection
branch
from
ea303bd to
5d16cdd
Compare
Contributor
Author
|
Rebased this onto current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LocalFilereads through the pinnedLocalDirpath handlingLocalDirparent directories before accepting opened filesTesting
uv run pytest -q tests/sandbox/test_entries.py -k "local_file_rejects_symlinked_source or local_dir_copy_fallback_rejects_swapped_parent_directory or local_dir_apply_fallback_rejects_source_root_swapped_to_symlink_after_validation"uv run ruff check src/agents/sandbox/entries/artifacts.py tests/sandbox/test_entries.pySigned-off-by: matthewflint 277024436+matthewflint@users.noreply.github.com