Skip to content

feat(data): normalize dataset to 2022 FIFA World Cup squad (#543) #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nanotaboada merged 2 commits into from
Apr 1, 2026

fix(data): address PR review findings (#543)

8c4b284
Select commit
Loading
Failed to load commit list.
Merged

feat(data): normalize dataset to 2022 FIFA World Cup squad (#543) #546

fix(data): address PR review findings (#543)
8c4b284
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Apr 1, 2026 in 25s

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check failure on line 96 in tools/seed_001_starting_eleven.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Liga Portugal" 3 times. 

See more on https://sonarcloud.io/project/issues?id=nanotaboada_python-samples-fastapi-restful&issues=AZ1FtiQRxuRvoptrNQ3A&open=AZ1FtiQRxuRvoptrNQ3A&pullRequest=546

Check failure on line 95 in tools/seed_001_starting_eleven.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "SL Benfica" 3 times. 

See more on https://sonarcloud.io/project/issues?id=nanotaboada_python-samples-fastapi-restful&issues=AZ1FtiQRxuRvoptrNQ2_&open=AZ1FtiQRxuRvoptrNQ2_&pullRequest=546
View more details on SonarQubeCloud