Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/dotnet-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,15 @@ jobs:
with:
fetch-depth: 0

- name: Verify tag commit is reachable from master
run: |
if ! git merge-base --is-ancestor ${{ github.sha }} origin/master; then
echo "❌ Error: Tag commit ${{ github.sha }} is not reachable from origin/master"
echo "Ensure the PR is merged to master before pushing a release tag"
exit 1
fi
echo "✅ Verified: commit is reachable from master"

- name: Extract version from tag
id: version
run: |
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ This project uses famous football stadiums (A-Z) that hosted FIFA World Cup matc

### Changed

- Add "Verify tag commit is reachable from master" step to CD workflow using `git merge-base --is-ancestor` before any build or publish steps (#439)

### Fixed

- `GET /players` now returns `200 OK` with an empty list `[]` when no players exist, instead of `404 Not Found` (#425)
Expand Down
Loading