fix(http): use @bodyRoot in HttpStream to eliminate spurious metadata-ignored warnings#10423
Open
n-sviridenko wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(http): use @bodyRoot in HttpStream to eliminate spurious metadata-ignored warnings#10423n-sviridenko wants to merge 1 commit intomicrosoft:mainfrom
n-sviridenko wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
Member
There was a problem hiding this comment.
@n-sviridenko can you show a repro of what you are seeing, I am not sure this is a correct fix.
Just using the stream as it is doesn't emit the warning. the content type header doesn't conflict as its not underneath that body. Do you have another header maybe inside the type, is that on purpose?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for creating such a lovely thing, that's something I was looking for for a while.
Problem
HttpStreamdefines@header contentTypealongside@body bodyin the same model. This triggers the@typespec/http/metadata-ignoredwarning on every instantiation ofHttpStream— includingSSEStreamfrom@typespec/sse:This warning fires from library code that users cannot modify, making it impossible to use
--warn-as-errorwithout suppressing a warning they didn't cause.Fix
Change
@body bodyto@bodyRoot bodyinHttpStream. This is exactly what the warning message recommends, and it allows@headerand body to coexist correctly.Test plan
@typespec/http/metadata-ignoredwarning when instantiatingSSEStream