test(format): expand date-time suite to 132 exhaustive RFC 3339 cases#891
Open
AcEKaycgR wants to merge 1 commit intojson-schema-org:mainfrom
Open
test(format): expand date-time suite to 132 exhaustive RFC 3339 cases#891AcEKaycgR wants to merge 1 commit intojson-schema-org:mainfrom
AcEKaycgR wants to merge 1 commit intojson-schema-org:mainfrom
Conversation
Member
|
Please respect the existing formatting of these tests and avoid making unnecessary whitespace changes. |
karenetheridge
requested changes
Apr 11, 2026
c20e88b to
339a28e
Compare
Contributor
Author
|
Thanks for the review, @karenetheridge. All three points have been addressed in the latest commit:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #965. This PR expands the
date-timeformat test suite from 29 to 132 cases across all drafts.The expansion is designed to provide complete coverage of RFC 3339 §5.6 ABNF and §5.7 prose constraints, serving as a standalone compliance target for implementors.Technical Coverage Details
The new cases cover every structural dimension of the grammar:
Tabsent, space/tab/duplicate instead ofT; colons absent/replaced/duplicated in time; hyphens absent/replaced in date.Z-only, numeric offsets (+/-HH:MM), missing offset, offset without colon (+0000),Zfollowed by numeric offset, offset sign variants (±,++,+-,-+), non-padded and 3-digit offset fields, and non-ASCII digits./and:), non-ASCII Bengali digits, negative prefixes, and year0000(valid) and9999(valid) limits.00rejection.secfracvalidation covering 1-digit, 19-digit (arbitrary precision), all-zeros, and non-ASCII mid-frac characters.Standards & Traceability
Following the style established in the
ipv4.jsonsuite[cite: 41], this PR adds a top-levelcommentfield citing the full RFC 3339 §5.6 ABNF and §5.7 prose rules. Additionally, it corrects one existing description: "an invalid date-time past leap second, UTC" is updated to "second 61 is above the absolute maximum of 60".Triangulation Results
The suite was validated against the following implementations:
These mismatches represent implementation differences from strict RFC 3339 compliance rather than errors in the test vectors.
Feedback on the coverage matrix and test structure is appreciated @jviotti @jdesrosiers