Skip to content

Allow webapp file creation on IRIS servers lacking the DP-442552 fix#1768

Merged
gjsjohnmurray merged 1 commit intointersystems-community:masterfrom
gjsjohnmurray:fix-1767
Apr 22, 2026
Merged

Allow webapp file creation on IRIS servers lacking the DP-442552 fix#1768
gjsjohnmurray merged 1 commit intointersystems-community:masterfrom
gjsjohnmurray:fix-1767

Conversation

@gjsjohnmurray
Copy link
Copy Markdown
Contributor

This PR fixes #1767

@isc-bsaviano
Copy link
Copy Markdown
Contributor

@gjsjohnmurray I'd prefer it if you made this change in writeFile() and only added the blank line for server versions that need it using api.serverVersion. We've seen issues in the past with web app files getting extra newlines appended. I don't have an issue reference handy though.

@gjsjohnmurray
Copy link
Copy Markdown
Contributor Author

@isc-bsaviano the change targets the new empty document very precisely so I don't foresee any risk.

If you're unconvinced please provide the complete set of api.serverVersion values that have the bug.

@gjsjohnmurray
Copy link
Copy Markdown
Contributor Author

I don't have an issue reference handy though.

Maybe what you fixed in #1648

Copy link
Copy Markdown
Contributor

@isc-bsaviano isc-bsaviano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, this is probably fine

@gjsjohnmurray gjsjohnmurray merged commit 3607aff into intersystems-community:master Apr 22, 2026
5 checks passed
@gjsjohnmurray gjsjohnmurray deleted the fix-1767 branch April 22, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<UNDEFINED>SetTextFromArray+14^%apiSRC *pDocumentArray(0) when creating a new file in an ISFS webapp folder

2 participants