Improve the accuracy of Storage update#1755
Merged
isc-klu merged 1 commit intointersystems-community:masterfrom Apr 13, 2026
Merged
Improve the accuracy of Storage update#1755isc-klu merged 1 commit intointersystems-community:masterfrom
isc-klu merged 1 commit intointersystems-community:masterfrom
Conversation
isc-bsaviano
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves accuracy by more carefully matching storage members.
Previously, we treated
}as the end of a storage definition. However, this check is incorrect when a storage contains{%%PARENT}(seeDataLocation (Storage Keyword)in the IRIS documentation).This PR improves accuracy by requiring a preceding
>(allowing intervening whitespace or newlines) before the closing}to identify the end of a storage definition.