🔒️ Add zizmor and fix audit findings#146
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
| persist-credentials: false | ||
| - uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0 | ||
| with: | ||
| bun-version: 1.3.12 |
There was a problem hiding this comment.
Version tag is still mutable, but it's better than latest.
I din't find a way to specify hash or checksum
There was a problem hiding this comment.
I think that's okay. In theory we could download via curl instead of using setup-bun but IMO, that's probably very marginal gain.
There was a problem hiding this comment.
Ideally, oven-sh/setup-bun should handle this.
For example, astral-sh/setup-uv does check the checksum: astral-sh/setup-uv#851 (comment) (still not ideal as we have to make sure that action knows this version)
There was a problem hiding this comment.
Ah interesting. Maybe we should file an issue on setup-bun to support this?
|
I'll merge this for now and we can revisit the setup-bun SHA if we decide we want that later. |
Changes applied:
dangerous-triggersrule forpull_request_target(checked that they are used in a safe way)secrets-outside-envrule as using the environments would require approval for each run (and without required approvals it wouldn't make sense)persist-credentials: falseforactions/checkoutwhen persisting is not needed by other stepslatest-changesto make it clear that it only runs for merged PRsbunto install foroven-sh/setup-bun(otherwise it installs latest, that is not safe)publish.ymlto use specific locked versions of tools instead of latest versionsdocker://agilepathway/pull-request-label-checker:latestaction with the action from GH marketplace to be able to pin it by SHAbun installwith--frozen-lockfileoption to ensure it fails ifpackage.jsondisagrees withbun.lock