-
-
Notifications
You must be signed in to change notification settings - Fork 80
✨ Add public-url option and env var
#381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
YuriiMotov
wants to merge
4
commits into
main
Choose a base branch
from
public_url-option
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -112,6 +112,7 @@ def _run( | |
| entrypoint: str | None = None, | ||
| proxy_headers: bool = False, | ||
| forwarded_allow_ips: str | None = None, | ||
| public_url: str | None = None, | ||
| ) -> None: | ||
| with get_rich_toolkit() as toolkit: | ||
| server_type = "development" if command == "dev" else "production" | ||
|
|
@@ -189,7 +190,7 @@ def _run( | |
| tag="app", | ||
| ) | ||
|
|
||
| url = f"http://{host}:{port}" | ||
| url = public_url.rstrip("/") if public_url else f"http://{host}:{port}" | ||
| url_docs = f"{url}/docs" | ||
|
|
||
|
Comment on lines
+193
to
195
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure we need this |
||
| toolkit.print_line() | ||
|
|
@@ -299,6 +300,13 @@ def dev( | |
| help="Comma separated list of IP Addresses to trust with proxy headers. The literal '*' means trust everything." | ||
| ), | ||
| ] = None, | ||
| public_url: Annotated[ | ||
| str | None, | ||
| typer.Option( | ||
| help="The public URL where the server is accessible. Used for the URLs printed at startup. Defaults to [blue]http://{host}:{port}[/blue].", | ||
|
YuriiMotov marked this conversation as resolved.
Outdated
|
||
| envvar="FASTAPI_PUBLIC_URL", | ||
| ), | ||
| ] = None, | ||
| ) -> Any: | ||
| """ | ||
| Run a [bold]FastAPI[/bold] app in [yellow]development[/yellow] mode. 🧪 | ||
|
|
@@ -337,6 +345,7 @@ def dev( | |
| command="dev", | ||
| proxy_headers=proxy_headers, | ||
| forwarded_allow_ips=forwarded_allow_ips, | ||
| public_url=public_url, | ||
| ) | ||
|
|
||
|
|
||
|
|
@@ -406,6 +415,13 @@ def run( | |
| help="Comma separated list of IP Addresses to trust with proxy headers. The literal '*' means trust everything." | ||
| ), | ||
| ] = None, | ||
| public_url: Annotated[ | ||
| str | None, | ||
| typer.Option( | ||
| help="The public URL where the server is accessible. Used for the URLs printed at startup. Defaults to [blue]http://{host}:{port}[/blue].", | ||
|
YuriiMotov marked this conversation as resolved.
Outdated
|
||
| envvar="FASTAPI_PUBLIC_URL", | ||
| ), | ||
| ] = None, | ||
| ) -> Any: | ||
| """ | ||
| Run a [bold]FastAPI[/bold] app in [green]production[/green] mode. 🚀 | ||
|
|
@@ -444,6 +460,7 @@ def run( | |
| command="run", | ||
| proxy_headers=proxy_headers, | ||
| forwarded_allow_ips=forwarded_allow_ips, | ||
| public_url=public_url, | ||
| ) | ||
|
|
||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can ignore this for now and add such guard if user report they need this (I think they will not)