Introduce javaparserVersion option to Cleanthat#2903
Open
blacelle wants to merge 5 commits intodiffplug:mainfrom
Open
Introduce javaparserVersion option to Cleanthat#2903blacelle wants to merge 5 commits intodiffplug:mainfrom
blacelle wants to merge 5 commits intodiffplug:mainfrom
Conversation
Contributor
Author
|
@nedtwigg I see the JDK matrix runs JDK24. I guess we should rather run JDK25, and potentially JDK26. |
Member
|
Feel free to make that change within this PR if it is helpful to you. |
Contributor
Author
|
@nedtwigg I see many failures, only on gradle side. One of them: Locally, I see stuff related with Cleanthat on some deprecation notices, but nothing new:
What am I missing? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Hi!
Small change over Cleanthat integration, enabling customization of Javaparser version over the one brought transitively by Cleanthat. It's helpful as a bunch of bugs in Cleanthat are actual fixed by only upgrading javaparser (e.g. covering recent JDK syntax).
I also upgrade the baseline to 2.25.