Skip to content

Introduce javaparserVersion option to Cleanthat#2903

Open
blacelle wants to merge 5 commits intodiffplug:mainfrom
blacelle:main
Open

Introduce javaparserVersion option to Cleanthat#2903
blacelle wants to merge 5 commits intodiffplug:mainfrom
blacelle:main

Conversation

@blacelle
Copy link
Copy Markdown
Contributor

Hi!

Small change over Cleanthat integration, enabling customization of Javaparser version over the one brought transitively by Cleanthat. It's helpful as a bunch of bugs in Cleanthat are actual fixed by only upgrading javaparser (e.g. covering recent JDK syntax).

I also upgrade the baseline to 2.25.

@blacelle
Copy link
Copy Markdown
Contributor Author

@nedtwigg I see the JDK matrix runs JDK24. I guess we should rather run JDK25, and potentially JDK26.

@nedtwigg
Copy link
Copy Markdown
Member

Feel free to make that change within this PR if it is helpful to you.

@blacelle
Copy link
Copy Markdown
Contributor Author

@nedtwigg I see many failures, only on gradle side. One of them:

Execution failed for task ':lib:spotbugsMain'.
> Task :lib:spotbugsTestCompatKtLint1Dot0Dot0
> A failure occurred while executing com.github.spotbugs.snom.internal.SpotBugsRunnerForHybrid$SpotBugsExecutor
   > Verification failed: SpotBugs ended with exit code 1. See the report at: file:///home/runner/work/spotless/spotless/lib/build/reports/spotbugs/main.html

Locally, I see stuff related with Cleanthat on some deprecation notices, but nothing new:
image

main is green, but we can see similar deprecation notice: https://github.com/diffplug/spotless/actions/runs/24608470721/job/72039556017

What am I missing?

@blacelle
Copy link
Copy Markdown
Contributor Author

Ha, it was explained in the other report:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants